Apply exclude patterns when shoveling into FileList#754
Open
hsbt wants to merge 1 commit into
Open
Conversation
FileList#<< pushed the new entry after resolve and never ran it through excluded_from_list?, so a name added after #exclude (or one matching a default ignore pattern such as core or *.bak) leaked into the list while #include correctly dropped it. Filter the appended name so #<< shares the same exclusion semantics as #include, which also means default ignore patterns now apply to shoveled entries. #637 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileList#<<pushed the appended entry afterresolveand never passed it throughexcluded_from_list?. A name added after#exclude, or one matching a default ignore pattern such ascoreor*.bak, stayed in the list even though#includedropped it. The two ways of adding a file disagreed on exclusion.This filters the appended name through the same
excluded_from_list?check that#includeandadd_matchingalready rely on, so#<<gains the exclusion semantics of#include. Default ignore patterns now apply to shoveled entries as well, which is a small behavior change worth noting for anyone that relied on#<<bypassing exclusion.#637